Issue #1721: Improve exceptional behavior in reactive streams #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Errors on the request are now propagated to reactive subscribers instead of just to the request's ListenableFuture * Read timeouts can no longer occur if a reactive streams subscriber has no outstanding request. Note that this does not affect request timeouts - only read timeouts.
n-miles
force-pushed
the
issue-1721-falsetimeouts
branch
from
eae757b to
cef8a26
Compare
|
@slandelle have you had a chance to look at this change? |
|
Honestly, I'm not familiar with reactive streams. Code style and test LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1721
Changes:
The original purpose of this change was to fix the read timeouts, but in the process of testing my change, I discovered that errors are not currently propagated to the subscriber, so I changed that as well.
I can split the changes into separate commits if you'd like.